We're updating the issue view to help you get more done. 

fix tablename for ofMucaffiliation

Description

case bug with MUCPersistenceManager.java

Environment

None

Acceptance Test - Entry

None

Activity

Show:
David Horwitz
September 5, 2008, 6:13 PM

relevent lines from at least one of the cases that throws this:

at $java.sql.PreparedStatement$$EnhancerByProxool$$a8cf99df.executeUpdate(<generated>)
at org.jivesoftware.openfire.muc.spi.MUCPersistenceManager.removeAffiliationFromDB(MUCPersistenceManager.java:956)
at org.jivesoftware.openfire.muc.MultiUserChatManager.userDeleting(MultiUserChatManager.java:835)
at org.jivesoftware.openfire.event.UserEventDispatcher.dispatchEvent(UserEventDispatcher.java:124)
at org.jivesoftware.openfire.user.UserManager.deleteUser(UserManager.java:188)
at org.jivesoftware.openfire.admin.user_002ddelete_jsp._jspService(user_002ddelete_jsp.java:93)

This will affect at least all users of mysql on *nix platforms

David Horwitz
September 5, 2008, 7:27 PM

Patch for this issue:

  1.  

    1.  

      1. Eclipse Workspace Patch 1.0
        #P openfire
        Index: src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java
        ===================================================================

      • src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (revision 10828)
        +++ src/java/org/jivesoftware/openfire/muc/spi/MUCPersistenceManager.java (working copy)
        @@ -112,7 +112,7 @@
        private static final String DELETE_USER_MEMBER =

"DELETE FROM ofMucMember WHERE jid=?";

private static final String DELETE_USER_MUCAFFILIATION =

  • "DELETE FROM ofMucaffiliation WHERE jid=?";

+ "DELETE FROM ofMucAffiliation WHERE jid=?";

private static final String ADD_CONVERSATION_LOG =

"INSERT INTO ofMucConversationLog (roomID,sender,nickname,logTime,subject,body) " +

"VALUES (?,?,?,?,?,?)";

Daryl Herzmann
September 5, 2008, 7:43 PM

Thanks David, your patch matches mine attached to the ticket

David Horwitz
September 5, 2008, 7:49 PM

doh missed that - so used to not having permission to attach files in this jira I forget to look for them

Daryl Herzmann
November 13, 2008, 11:15 AM

This bug is trivial , assigning as blocker

Assignee

Gaston Dombiak

Reporter

Daryl Herzmann

Labels

None

Expected Effort

None

Ignite Forum URL

None

Components

Fix versions

Affects versions

Priority

Blocker
Configure