We're updating the issue view to help you get more done. 

AdminManager doesn't handle JIDs properly.

Description

The list of admins in an Openfire instance is represented as List<JID>. Usually, the list will contain bare JIDs. The methods that check if a particular JID represents an admin, doesn't make sure that the JID that's being checked is also a bare JID.

If the JID that is being checked is retrieved from a 'to' or 'from' attribute in a stanza, there's a good chance that that JID is actually a full JID. The isAdmin() check will always fail in those cases.

AdminManager should make sure that the list consists of bare JIDs. Checks should also always use bare JIDs.

Environment

None

Acceptance Test - Entry

None

Activity

Show:
Guus der Kinderen
November 14, 2008, 5:16 PM

The attached patch makes sure that all JID management in org.openfire.admin.AdminManager is done using bare JIDs only.

Fixed

Assignee

Gaston Dombiak

Reporter

Guus der Kinderen

Labels

None

Expected Effort

None

Ignite Forum URL

None

Components

Fix versions

Priority

Minor
Configure