Chat notification (xep-0085 vs xep-0022)

Description

Imported issue was from koyao:
Hi Daniel,

Does Kraken implement XEP-0085 (Chat State Notification), or the deprecated XEP-0022 (Message Events) standard?

Looking at BaseTransport.java, it seems like sendComposingNotification() implements XEP-0085, whereas sendComposingPausedNotification() implements XEP-0022.

XEP-0085 : http://xmpp.org/extensions/xep-0085.html#example-11
XEP-0022 : http://xmpp.org/extensions/xep-0022.html#example-4 (note the presence of "jabber:x:event" xmlns)

I think a lot of legacy clients are still sending and parsing XEP-0022, despite it being deprecated. So here's a patch to make sendComposingPausedNotification() send XEP-0022 style message instead:

http://konline.org/koyao/kraken_patch3.txt

I tested with Yahoo messenger and iChat and both the composing and paused events are being parsed correctly.

Thanks,
Yao

Environment

None

Activity

Show:
daniel vultur
September 4, 2009, 12:42 AM

Hey, I modified the patch some because:
1. there were other states that should correspond with "goodbye composing"
2. the patch you submitted removed chatstates support from the paused notification ;D

Anyway it's all fixed up now! Thanks!

daniel vultur
September 1, 2009, 6:29 AM

Imported comment was from koyao:
Here's the new URL:

http://konline.org/koyao/patches/kraken_patch3.txt

Thanks,
Yao

daniel vultur
September 1, 2009, 1:11 AM

Again I can't find the patch on your site =) would you mind attaching it to this issue?

Fixed

Assignee

Daniel Henninger

Reporter

Daniel Henninger