Pubsub event message with SHIM information holding multiple subscriptions should have the name='SubID'.

Description

Event message with SHIM information holding multiple subscriptions should have the name='SubID', not 'pubsub#subID' as it is currently

This may be a version issue as opposed to a defect.

Environment

None

Activity

Show:
Robin Collier
March 7, 2014, 1:29 PM

Yes, there are many more than these 3 changes. These are just a few that popped up either from the forums or when I was doing some other coding. All of them logged many years (and a couple of versions of the spec) ago.

As for whether it is acceptable, that is why I said Guus should be consulted, ultimately it is his decision.

This will probably break the Smack code as well, as it adheres to the same version of the spec.

csh
March 7, 2014, 7:20 AM

Sorry, didn't knew that. I only browsed Jira for issues, I could fix.
On the other hand suggests that there are only 3 sub tasks to fix and you are done. In reality though, there a far more changes (like 30?) between 1.8 and 1.13. Implementing either all of them or none of them, seems like a hard task.
I don't see it that critical, if only parts of a newer specification are implemented.

Robin Collier
March 6, 2014, 7:24 PM
Edited

This should only be fixed as part of the parent task. On it's own it makes for inconsistent version adherence. By changing this without updating the rest of pubsub to the latest version, it will not be consistent with any specific version of the spec.

I haven't been keeping tabs, but unless someone has updated the code to a later version, pubsub is currently compliant with version 1.8.

Guus should be consulted to see if this is acceptable.

Note: That is why it wasn't fixed a long time ago. The fix is trivial, but the spec update is not.

csh
March 6, 2014, 4:34 PM

Yes, it was. Now fixed.

Daryl Herzmann
February 23, 2013, 12:14 PM

Hi Robin, Is this still valid?

Fixed

Assignee

Unassigned

Reporter

Robin Collier