Persistent pubsub nodes will not store items unless max_items is set.
Persistent nodes will not store items unless the max_items is set. Otherwise, it will check for size greater than -1 (unset max number) and never persist.
Checks properly when max_items is not set
It is, as mentioned in my first comment.
This patch seems to be the exact same diff that was attached to OF-17. If that is the case then it is fine by me.
I seriously underestimated the complexity of the code, when I agreed to do the code review. I've asked Gato for help. He agreed to review the patch if he can find the time.
This is the fix for and OF-17.