Error when remote user subscribes to local user

Description

When a remote JID performs a subscription request to a local user, the following is logged right after the local user accepts the subscription request.

There's code in `PresenceSubscribeHandler` that blindly assumes that the sender of a `subscribed` stanza is a local user (see how 'senderJID.getNode()` is used, without a check if senderJID is a local user):

I've reproduced this with Converse 4.1.2.

Environment

None

Activity

Show:
Daryl Herzmann
June 18, 2019, 1:40 PM

About to dogfood this on ignite to test it.

Fixed

Assignee

Dave Cridland

Reporter

Guus der Kinderen

Labels

None

Expected Effort

None

Ignite Forum URL

None

Fix versions

Priority

Major
Configure