Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Prevent NPE when admin page obtained without session

Description

When trying to access an admin console page, servlet-code will try to obtain the user corresponding to the web session. This fails when there's no session in the first place, but fails with an ugly stacktrace logged to debug.

2021.11.02 09:06:02 DEBUG [Jetty-QTP-AdminConsole-42812]: org.jivesoftware.util.WebManager - Unexpected exception (which is ignored) while trying to obtain user java.lang.NullPointerException: null at org.jivesoftware.util.WebManager.getAuthToken(WebManager.java:79) ~[xmppserver-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT] at org.jivesoftware.util.WebManager.getUser(WebManager.java:162) ~[xmppserver-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT] at org.jivesoftware.util.WebManager.getPageProperty(WebManager.java:367) ~[xmppserver-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT] at org.jivesoftware.util.WebManager.getRowsPerPage(WebManager.java:323) ~[xmppserver-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT] at org.jivesoftware.openfire.admin.user_002droster_jsp._jspService(user_002droster_jsp.java:164) ~[xmppserver-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT] at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:71) ~[apache-jsp-8.5.54.jar:8.5.54]

Handle this more gracefully.

Environment

None

Activity

Show:
Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created November 2, 2021 at 3:55 PM
Updated November 2, 2021 at 4:52 PM
Resolved November 2, 2021 at 4:52 PM

Flag notifications