Unnecessary socket open for outbound connections

Description

Found in Openfire 4.8.0 pre-release

 

When opening an S2S connection, we use a plain Socket connection to establish which DNS entry is contactable.

We then immediately use that socket’s remote address to create a new bootstrapped Netty channel (another socket connection that we’ll actually use for XMPP).

  1. This is inefficient and we probably shouldn’t do this

  2. We should definitely explicitly close that initial socket

Environment

None

Activity

Show:

Dan Caseley December 8, 2023 at 9:53 AM

A PR was raised that tidies up the extra connection after use.

The remaining work is to remove use of the socket at all.

Details

Assignee

Reporter

Affects versions

Priority

Created November 10, 2023 at 12:06 PM
Updated December 8, 2023 at 9:53 AM