Current OfflineMessageStore logic discards valid MUC invites

Description

OfflineMessageStore currently discards any messages with an empty body.

An exception is made for PubSub events (See ) as (I assume) these don't need a body to be useful to the recipient.

Another example of a valid message which doesn't have a body is a MUC invite.

e.g.

<message
from='crone1@shakespeare.lit/desktop'
to='hecate@shakespeare.lit'>
<x xmlns='jabber:x:conference'
jid='darkcave@macbeth.shakespeare.lit'
password='cauldronburn'
reason='Hey Hecate, this is the place for all good witches!'/>
</message>

These messages are currently discarded when the user is offline - instead, they should be stored according to the current offline message storage strategy

Environment

None

Activity

Show:
csh
February 14, 2014, 7:13 PM

Fixed by

csh
February 11, 2014, 9:32 PM

Ashley Ward's patch looks very good! The attached diff unfortunately only deals with MUC invites, but does not consider XEP-160.

csh
February 11, 2014, 9:26 PM

I believe this issue has the same cause as in

Daryl Herzmann
July 18, 2013, 3:34 PM

I've elevated your Jira privs, so you can triage tickets, etc. Once Guus reviews a few of your patches, we'll get you onboard.

Ashley Ward
July 18, 2013, 3:27 PM

That would be great

Fixed

Assignee

Guus der Kinderen

Reporter

Simon White