Packet filter plugin's error in a form checking if destJID is not empty

Description

from the thread:

Well purpose of that line is to check if destJID entered is NOT empty. Instead of checking length of destJID it is checking length of sourceJID.

Original coder seems to have copy-pasted and modified line 145 which checks sourceJID.

So when modifying the line 171 (which is copy of 145) for destJID, original coder forgot about modifying OR (||) side of if condition.

rule-edit-form.jsp file in Packet Filter plugin, line 171:

if (destJID == null || !(sourceJID.length() > 0)) {

this should actually be

if (destJID == null || !(destJID.length() > 0)) {

Environment

None

Activity

Show:
wroot
October 26, 2015, 7:08 PM

Looks like this was already fixed at some point.

wroot
March 1, 2013, 9:12 AM

Nate is probably not active on this project. Feel free to reassign this ticket and provide a patch.

Fixed

Assignee

Unassigned

Reporter

wroot

Expected Effort

None

Ignite Forum URL

None

Components

Affects versions

Priority

Minor