Spark should show 24h time stamps in a previous conversation history

Description

Currently if one have selected a 24h format of time, then Spark is showing time stamps in 24h format, but only for the current conversation. If you close and reopen the chat, then all time stamps will be in 12h format. I think all time stamps (in the current chat, in the previous conversation history, in the full history) should be shown in 24h format after the user change that option. This means, old time stamps, when the 24h option wasnt turned on can stay as they are.

Environment

None

Activity

Show:
Mike McMahon
November 15, 2010, 10:40 PM

awesome!

wroot
November 13, 2010, 8:41 PM

Patch is working.

Mike McMahon
November 13, 2010, 7:18 PM

This patch should fix the problem with the display of the dates.

getDate(Date) calls pref.getTimeFormat() which should resolve to either 24h or 12h time based on the users preferences.

wroot
November 13, 2010, 11:42 AM

We can always test a patch and say if something is wrong with it. I will assign this task to you as soon as Daryl will ad you to the list of devs.

Mike McMahon
November 13, 2010, 5:18 AM

Looks pretty straight forward unless I am missing something. Updating the insertHistoryMessage() method (line 371 in the TranscriptWindow class)

from: value = "(" + messageDateFormatter.format(date) + ") ";
to: value = getDate(date);

Does the trick. I'm new to the Spark source and not sure if this would have any negative repercussions; however, if this looks good you can assign it to me and I will create a patch and submit it through the proper channels.

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Priority

Minor

Assignee

Mike McMahon

Reporter

wroot