Spark is getting stuck with On Phone status after unlocking Windows

Description

User receives a call, accepts it and his status changes to "On Phone"
While talking on the phone Windows session locks up (manually or automatically)
Status changes to Available (should be Away)
User hangs up a phone and unlocks Windows session
Status changes back to "On Phone"

Looks like Spark is saving the last known status before the locking up and then restores it without checking whether user is still one the phone. Or maybe it only changes "On Phone" status to the other when it receives some special "hang up" signal which it can't receive in the locking state. Should be a fail check in this place to prevent infinite "On Phone" status.

Environment

Windows 7 x64 (probably other Windows versions)
Openfire 3.7.1 with Asterisk IM plugin 1.4.0

Activity

Show:
wroot
March 13, 2016, 8:03 PM

User in the forums reports that the latest patch fixes the issue.

speedy
March 9, 2016, 5:04 AM

Did some more hacking on this. Found a few conflicts/presence issues. submitted PR #103, which is probably the very long, and least efficient way of doing things, but I feel like I've been able to address all the conflicts that I've encountered.

speedy
March 7, 2016, 9:15 PM

made a few changes. local testing, this seems to work well.

Guus der Kinderen
January 31, 2016, 7:34 PM

Don't worry about wildcard imports. The only issue here is when you have classes with the same name in different packages, which does occur, but rarely is an actual problem Whatever the default setting of your IDE is, is fine.

speedy
January 31, 2016, 3:55 PM
Edited

I think my IDE did that automatically, and I didn't notice it. I upgraded recently, so maybe that got switched on. I''ll disable that "feature"!

I don't know what the pros/cons of using wildcards vs more specific ones.

Fixed

Priority

Minor

Assignee

speedy

Reporter

wroot

Affects versions

Fix versions

Components