Privacy plugin could freeze spark at startup

Description

If user has lots of contacts, retrieving data while startup could take a while and make spark freeze for some time.

Environment

None

Activity

Show:
Tim Jentz
April 11, 2012, 12:16 PM

Internal patch committed to trunk

Tim Jentz
June 6, 2012, 8:20 AM

Discovered an additional spot in privacy plugin

Tim Jentz
June 6, 2012, 8:44 AM

The getInstance-method of the Privacy-Plugin could freeze spark if it takes to long.
This patch initializes the Privacy-Plugin in a thread.
Additionally, the PrivacyManager try to discover the xmppHost, if this response take to long, the host will not be discovered at all.
This patch will resolve this problem by try to discover the xmpphost again, after timeout.

Mircea Carasel
June 9, 2012, 11:20 AM

r13104 = 66d153a5b14bf1f42f5a113cec0b760a890a5bee (refs/remotes/git-svn)

-remove infinite loops as it causes out of memory (in TransportUtils.java and PrivacyManager.java)
If there is really necessary to try more times, a Thread Pool may be used: java ScheduledThreadPoolExecutor for example

-remove timer task when bookmark plugin is initialized, as it very often
causes: Exception in thread "AWT-EventQueue-0" java.lang.ArrayIndexOutOfBoundsException: 1 > 0
when spark starts

wroot
March 27, 2014, 2:58 PM

Marking as resolved per Mircea's commit.

Fixed

Assignee

Tim Jentz

Reporter

Tim Jentz

Labels

None

Expected Effort

None

Ignite Forum URL

None

Fix versions

Priority

Major
Configure