We're updating the issue view to help you get more done. 

Fastpath plugin is not working after Smack 3.4.0 update

Description

After the Smack update in recent commits Fastpath seems to be broken in Spark. There was a build failure until smackx-workgroup.jar has been added into the mix. But, the working version (Spark 2.7.4 - Smack 3.3.1) doesn't have this library in the libs folder.

I guess there was some change in 3.4.0 version which brakes Fastpath behavior. Maybe this one https://igniterealtime.org/issues/browse/SMACK-381

I think some users will be annoyed by the absence of Fastpath in 2.7.5, so we would probably have to revert Smack update if no fix can be done about this.

Environment

None

Acceptance Test - Entry

None

Activity

Show:
wroot
January 12, 2016, 5:08 AM

FastpathPlugin.java is filled with "can't resolve" errors pointing to smackx. I guess Robin has moved workgroups code from smack main library to smacx-workgroups and one has to update Fastpath plugin's code to accommodate that.

15 java files in total that needs fixing of imports.

wroot
January 12, 2016, 9:29 PM
Edited

After adding smackx-worgroups.jar to the buildpath i was able to get rid of import errors. But i still can't get Fastpath working after building Spark. Getting this Exception:

Exception in thread "Thread-17" java.lang.ClassCastException: org.jivesoftware.smack.util.PacketParserUtils$UnparsedResultIQ cannot be cast to org.jivesoftware.smackx.workgroup.packet.AgentWorkgroups
at org.jivesoftware.smackx.workgroup.agent.Agent.getWorkgroups(Agent.java:49)
at org.jivesoftware.fastpath.FastpathPlugin$2.construct(FastpathPlugin.java:120)
at org.jivesoftware.spark.util.SwingWorker$2.run(SwingWorker.java:141)

So it is this code not going through (though, maybe this is just the first culprit and there will be more after this is fixed):

return Agent.getWorkgroups(workgroupService, jid, SparkManager.getConnection());

And i don't know what is wrong with it. I get that in Smack 3.4.0 all workgroups classes has been moved to smackx-worgroups.jar And there is Agent.GetWorkgroups there and it expects String, String and Connection like that code is querying. That's too complex for me

wroot
May 7, 2016, 7:03 AM

Closing as we have already upgraded to Smack 4 and there is a new ticket about this.

Won't Fix

Assignee

Unassigned

Reporter

wroot

Labels

Expected Effort

None

Ignite Forum URL

None

Components

Priority

Major
Configure