We're updating the issue view to help you get more done. 

Disconnecting when saving or retrieving Notes

Description

When a user tries to save a text which has "&" in it, Spark will disconnect from the server and not save this text.

Exception:
Mar 02, 2016 9:39:26 PM org.jivesoftware.spark.util.log.Log error
SEVERE:
No response from the server.:
at org.jivesoftware.smackx.PrivateDataManager.setPrivateData(PrivateDataManager.java:255)
at org.jivesoftware.sparkimpl.plugin.scratchpad.PrivateNotes.savePrivateNotes(PrivateNotes.java:128)
at org.jivesoftware.sparkimpl.plugin.scratchpad.ScratchPadPlugin$16.actionPerformed(ScratchPadPlugin.java:510)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at org.pushingpixels.substance.internal.utils.RolloverButtonListener.mouseReleased(RolloverButtonListener.java:124)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$500(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Another user reports he can't open his notes and Spark disconnects when he tries to do this. Similar exception is logged:

Μαρ 02, 2016 1:08:31 ΜΜ org.jivesoftware.spark.util.log.Log error

SEVERE:
No response from the server.:
at org.jivesoftware.smackx.PrivateDataManager.getPrivateData(PrivateDataManager.ja va:209)
at org.jivesoftware.sparkimpl.plugin.scratchpad.PrivateNotes.getPrivateNotes(Priva teNotes.java:143)
at org.jivesoftware.sparkimpl.plugin.scratchpad.ScratchPadPlugin$14.construct(Scra tchPadPlugin.java:430)
at org.jivesoftware.spark.util.SwingWorker$2.run(SwingWorker.java:141)
at java.lang.Thread.run(Unknown Source)

Could be a server's issue (server refusing to accept this text into a private storage).

Environment

None

Acceptance Test - Entry

None

Activity

Show:
wroot
March 2, 2016, 8:02 PM

As Smackx is first in the log i suspect this might be some parsing bug in the Smack version Spark uses (3.3.1). Which is very old and this issue might be already fixed in the new version, but we can't update as it brakes Fastpath and maybe a few other things.

wroot
March 13, 2016, 8:00 PM

Merged a patch from Alexander198961 https://github.com/igniterealtime/Spark/pull/107

Fixed

Assignee

wroot

Reporter

wroot

Expected Effort

None

Components

Fix versions

Affects versions

Priority

Minor
Configure