Use a key-based lookup to find an emoticon

Description

When Spark tries to display an emoticon, it iterates over all emoticons until it finds the correct one. That's easily improved upon by using a dictionary-based lookup.

Environment

None

Activity

Show:
wroot
July 22, 2017, 9:03 AM

For some reason ": D" (without space) and ":- D" stopped working in Spark (not replacing with emoticon). Will look into this myself.

wroot
July 22, 2017, 9:50 AM

It looks like Spark can't parse keys with only capital letters in equivalents now. If i add ": d" and ":- d" to its equivalents, grin icon starts to work. I can change all the packs by adding these strings (though grin icon usually is presented with capital D only), but maybe there is an easier programmatic fix. Before that change it was doing

if (key.toLowerCase().equals(string.toLowerCase()))

Which was converting ": d" to grin icon as well, so maybe changing the packs would have the same result.

wroot
July 22, 2017, 9:56 AM

Another thing to keep in mind if going the packs updating route. Spark may not the updating emoticons packs upon update (this might not be the case with the installer doing uninstall, but not sure).

wroot
July 23, 2017, 10:21 AM
Fixed

Assignee

Guus der Kinderen

Reporter

Guus der Kinderen

Labels

None

Expected Effort

None

Ignite Forum URL

None

Components

Fix versions

Affects versions

Priority

Minor