Add a popup for accepting certificate from a connection


Currently user need to manually add every certificate which he want to trust. There should be popup which will ask user if he want to add and accept certificate which he received from server which isn't part of his TrustStore.




August 26, 2018, 9:28 PM

Had to fix it in one more place. Marking this as resolved now.

Paweł Ścibiorski
August 26, 2018, 8:54 PM

I hope accept might be better than OK so I PRed that.

August 26, 2018, 7:20 PM

OK sometimes just means closing a window. So, if we change Add to Show in the list of chains, then i would like to change OK to Add in the details window then, to emphasize to the user that something will be added. Although i have no strong preference here. Can be left as it is. Will change Advanced to Details though. And i have filed green checkmark issue as SPARK-2071, so we can close this ticket finally

Paweł Ścibiorski
August 26, 2018, 6:02 PM

I think Details instead Advanced would be good.

I would left OK because I wanted to distinguish between just Adding certificate in first menu and confirming which certificates are added in Detailed menu.

August 26, 2018, 1:43 PM

Ok, i think i understand now. Yes, i think it is better to rename Add - to Show on the chain dialog window, as it doesn't get added when you press it, until you press OK in the details view. Also, on the details view i would rename OK to Add. Advanced should be renamed too (i have renamed it to Certificate, but it is not correct). Not sure how to name it though. Maybe "Check Chain" or "Certificate Chain" or something.

I can probably do all these changes myself. Though you can probably do this faster. But as you wish.





Paweł Ścibiorski


Paweł Ścibiorski