URL parser issues

Description

Two bugs with the URL parser:

1) A single "\" character is treated as a clickable link, which makes no sense.
2) "http://www.jivesoftware.com/" --> the trailing slash and quote characters are stripped. Additionally, the first quote appears to be part of the clickable URL.

Environment

None

Activity

Show:
Andrew Seymour
April 24, 2008, 5:15 AM
Edited

Okay so, added two new patch files. Network paths will work as \\network\mynetwork\files\amazing.file and now supports http://myhost/ basically, orange links indicate local links, and blue links are URLs, or, that's the plan at least.

Andrew Seymour
April 24, 2008, 5:14 AM

V2 part a of the patch (affects chatarea.java)

Daniel Henninger
April 24, 2008, 2:36 AM

Oh right, that was a bad example =)

Either way, environmental URLs should work as they are commonly passed around a business environment. (especially at jive lol)

Andrew Seymour
April 24, 2008, 2:24 AM
Edited

Okay, so, i just tested that URL in it, and it worked... even though i know by the code, that shouldn't of worked, but, it's another spark mystery. Although one thing that wont work is http://myhost/ seen as that to me is an environmental URL of the OS and not of the general internet. Although, it really does depend if anyone has a URL like that.

Daniel Henninger
April 24, 2008, 12:23 AM

Howdy! One possible problem I see with this patch is that often we'll send url's to each other like:

http://myhost/file/to/get.txt

note that there's no domain on that hostname so it wouldn't get highlighted via this patch.

Fixed

Priority

Major

Assignee

Andrew Seymour

Reporter

MattM