improve org.jivesoftware.openfire.user.JDBCUserProvider

Description

in the class "org.jivesoftware.openfire.user.JDBCUserProvider",in line 137,the implements is as follow:

String name = rs.getString(1);
String email = rs.getString(2);

return new User(username, name, email, new Date(), new Date());

i wonder why i cant be like this:

String name = rs.getString(nameField);
String email = rs.getString(emailField);

if it change like this, we dont have to care the order of the sql "jdbcUserProvider.loadUserSQL" like this
"SELECT name,email FROM myUser WHERE user = ?"

or this

"SELECT email,name FROM myUser WHERE user = ?"

Environment

None

Activity

Show:
Guus der Kinderen
May 10, 2011, 4:24 PM

The Tinder issue tracker is not meant to be used to report Openfire issues. For Openfire, we've opted not to open up this issue tracker, but have users report bugs through the community website at http://community.igniterealtime.org/ - Please report your bug there instead.

Incomplete
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Guus der Kinderen

Reporter

chengyaoan