We're updating the issue view to help you get more done. 

ExternalComponent should shutdown the component

Description

http://www.igniterealtime.org/community/message/198763

have written an external component implementing the Component interface which I then add to the ExternalComponentManager. Inside this method my component is wrapped into the ExternalComponent, which does some stuff like starting the component, calling the process(Packet) method and so on.

However, if I remove my component from the ExternalComponentManager, it calls shutdown on the wrapper, but the wrapper does not call it on the wrapped component. The consequence is, that my component never receives anything to shutdown, which is very problematic!

ExternalComponent.class (lines 370 - 373)

public void shutdown() {
shutdown = true;
disconnect();
}

Should be:

public void shutdown() {
shutdown = true;

// Notify the component to shutdown
component.shutdown();
disconnect();

}

Cheers,

Adam

Environment

None

Acceptance Test - Entry

None

Activity

Show:
Guenther Niess
December 14, 2009, 1:07 AM

Reviewed and commited patch to revision 11457. Thanks Adam!

Fixed

Assignee

Gaston Dombiak

Reporter

Guenther Niess

Labels

None

Expected Effort

None

Ignite Forum URL

None

Components

Priority

Major
Configure