Roster request denial is not pushed back to requester
Description
Environment
None
Activity
Show:
Guus der Kinderen November 15, 2023 at 3:46 PM
I believe this is introduced by the fix for https://igniterealtime.atlassian.net/browse/OF-317.
Guus der Kinderen November 15, 2023 at 2:52 PM
This is still reproducable in the current main branch (which is in a state prior to 4.8.0-beta):
15:44:44 SENT (0):
<iq id='XZE47-19' type='set'>
<query xmlns='jabber:iq:roster'>
<item jid='jane@example.org' name='Jane' subscription='none'>
</item>
</query>
</iq>
15:44:44 RECV (0):
<iq type="set" id="547-24" to="john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0">
<query xmlns="jabber:iq:roster" ver="1867767543">
<item jid="jane@example.org" name="Jane" subscription="none"/>
</query>
</iq>
15:44:44 RECV (0):
<iq type="result" id="XZE47-19" from="john@example.org" to="john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0"/>
15:44:44 SENT (0):
<presence to='jane@example.org' id='9WA5I-12' type='subscribe'/>
Entries added: jane@example.org
15:44:44 SENT (0):
<iq id='547-24' type='result'>
</iq>
15:44:44 RECV (0):
<iq type="set" id="993-28" to="john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0">
<query xmlns="jabber:iq:roster" ver="400600862">
<item jid="jane@example.org" name="Jane" ask="subscribe" subscription="none"/>
</query>
</iq>
Entries updated: jane@example.org
15:44:44 SENT (0):
<iq id='993-28' type='result'>
</iq>
15:44:44 RECV (1):
<presence to="jane@example.org" id="9WA5I-12" type="subscribe" from="john@example.org"/>
15:44:44 SENT (1):
<presence to='john@example.org' id='VZL3F-13' type='unsubscribed'/>
15:44:44 RECV (0):
<presence to="john@example.org" id="VZL3F-13" type="unsubscribed" from="jane@example.org"/>
15:44:44 RECV (0):
<presence type="unavailable" from="jane@example.org/13c0942b-4d92-4978-8196-ce78c34dc823" to="john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0"/>
Presence change: Presence Stanza [to=john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0,from=jane@example.org/13c0942b-4d92-4978-8196-ce78c34dc823,type=unavailable,]
15:44:45 RECV (0):
<iq type="get" id="151-33" to="john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0" from="example.org">
<query xmlns="jabber:iq:version"/>
</iq>
15:44:45 SENT (0):
<iq to='example.org' id='151-33' type='error'>
<error type='modify'>
<not-acceptable xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
</error>
</iq>
15:44:45 RECV (1):
<iq type="get" id="342-34" to="jane@example.org/13c0942b-4d92-4978-8196-ce78c34dc823" from="example.org">
<query xmlns="jabber:iq:version"/>
</iq>
15:44:45 SENT (1):
<iq to='example.org' id='342-34' type='error'>
<error type='modify'>
<not-acceptable xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
</error>
</iq>
Presence change: Presence Stanza [from=jane@example.org/13c0942b-4d92-4978-8196-ce78c34dc823,type=unavailable,]
15:44:48 SENT (0):
<presence id='9WA5I-13' type='unavailable'/>
</stream:stream>
15:44:48 RECV (0):
<presence id="9WA5I-13" type="unavailable" from="john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0" to="john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0"/>
15:44:48 RECV (0):
</stream:stream>
15:44:48 XMPPConnection closed (XMPPTCPConnection[john@example.org/fa95571f-36f8-4660-a77e-33dff2edeaa0] (0))
Presence change: Presence Stanza [from=jane@example.org/13c0942b-4d92-4978-8196-ce78c34dc823,type=unavailable,]
15:44:48 SENT (1):
<presence id='VZL3F-14' type='unavailable'/>
</stream:stream>
15:44:48 RECV (1):
<presence id="VZL3F-14" type="unavailable" from="jane@example.org/13c0942b-4d92-4978-8196-ce78c34dc823" to="jane@example.org/13c0942b-4d92-4978-8196-ce78c34dc823"/>
15:44:48 RECV (1):
</stream:stream>
We recently upgraded from Openfire 3.9.3 and Openfire 4.0.2 and we are seeing some issues.
A requests to add B in his roster
B denies A's contact request
A does not receive a roster push for the denial
A's roster still shows B in the roster with pending request.
When i switch back to Openfire 3.9.3 the roster push is sent to A and he has the correct entry in the roster.
Can somone please look into this issue and open a defect?