Subscription items include and 'affiliation' attribute which is not in the schema. This is returned in the request for subscriptions.
Patch removes the offending attribute.
Was the attribute "affiliation" removed in the spec? If yes then this patch is fine by me.
Version 1.12 Subscription schemas
Namespace: http://jabber.org/protocol/pubsub#event
Schema:
<xs:element name='subscription'>
<xs:complexType>
<xs:simpleContent>
<xs:extension base='empty'>
<xs:attribute name='expiry' type='xs:dateTime' use='optional'/>
<xs:attribute name='jid' type='xs:string' use='required'/>
<xs:attribute name='node' type='xs:string' use='optional'/>
<xs:attribute name='subid' type='xs:string' use='optional'/>
<xs:attribute name='subscription' use='optional'>
<xs:simpleType>
<xs:restriction base='xs:NCName'>
<xs:enumeration value='none'/>
<xs:enumeration value='pending'/>
<xs:enumeration value='subscribed'/>
<xs:enumeration value='unconfigured'/>
</xs:restriction>
</xs:simpleType>
</xs:attribute>
</xs:extension>
</xs:simpleContent>
</xs:complexType>
</xs:element>
Namespace: http://jabber.org/protocol/pubsub
Schema:
<xs:element name='subscription'>
<xs:complexType>
<xs:sequence>
<xs:element ref='subscribe-options' minOccurs='0'/>
</xs:sequence>
<xs:attribute name='jid' type='xs:string' use='required'/>
<xs:attribute name='node' type='xs:string' use='optional'/>
<xs:attribute name='subid' type='xs:string' use='optional'/>
<xs:attribute name='subscription' use='optional'>
<xs:simpleType>
<xs:restriction base='xs:NCName'>
<xs:enumeration value='none'/>
<xs:enumeration value='pending'/>
<xs:enumeration value='subscribed'/>
<xs:enumeration value='unconfigured'/>
</xs:restriction>
</xs:simpleType>
</xs:attribute>
</xs:complexType>
</xs:element>
Looks like this was a change between version 1.7 and 1.8 of the spec. Since the server is supposed to be 1.8 anyway, I will commit this patch.
Removed attribute