Migrated System Properties report that restart is needed
Description
A SystemProperty that is not ‘dynamic’ will report that Openfire needs to be restarted, when its current value is different from its initial value.
When a property is migrated (from XML), then this almost always is the case (it’s very noticeable with xmpp.domain). This seems to be caused by the way the migration takes place:
The SystemProperty is used to reference the key that is to be migrated. By doing so, it gets initialized. Only when the key is obtained, the property value is migrated, causing the SystemProperty to always have a different value than it’s initial (null) value.
This leads to a scenario that Openfire has properties that request a server restart, even though Openfire has just finished starting up. Can we improve on this?
A
SystemPropertythat is not ‘dynamic’ will report that Openfire needs to be restarted, when its current value is different from its initial value.When a property is migrated (from XML), then this almost always is the case (it’s very noticeable with
xmpp.domain). This seems to be caused by the way the migration takes place:JiveGlobals.migrateProperty(XMPPServerInfo.XMPP_DOMAIN.getKey());The
SystemPropertyis used to reference the key that is to be migrated. By doing so, it gets initialized. Only when the key is obtained, the property value is migrated, causing theSystemPropertyto always have a different value than it’s initial (null) value.This leads to a scenario that Openfire has properties that request a server restart, even though Openfire has just finished starting up. Can we improve on this?