Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Don't overly verbose log receiving IQ responses addressed to the server

Description

Openfire sometimes receives an IQ response stanza, addressed to the server itself. This could, for example, be a response to a query that it sent out earlier, such as a version check.

Some of these responses, which aren’t an IQ GET or SET request, generate very verbose errors. That’s unneeded.

Example of a response that would be better logged to ‘debug’ rather than ‘error’:

2023.09.06 16:38:20 ERROR [TaskEngine-pool-479]: org.jivesoftware.openfire.handler.IQHandler - Internal server error java.lang.IllegalArgumentException: IQ must be of type 'set' or 'get'. Original IQ: <iq type="error" id="951-4412" to="igniterealtime.org" from="demo@example.de/gajim.HVKMG82RQHXM8F0Q"><query xmlns="http://jabber.org/protocol/disco#info"/><error code="404" type="cancel"><remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/></error></iq> at org.xmpp.packet.IQ.createResultIQ(IQ.java:378) ~[tinder-2.0.0.jar:?] at org.jivesoftware.openfire.disco.IQDiscoInfoHandler.handleIQ(IQDiscoInfoHandler.java:139) ~[xmppserver-4.8.0-SNAPSHOT.jar:4.8.0-SNAPSHOT] at org.jivesoftware.openfire.handler.IQHandler.process(IQHandler.java:62) ~[xmppserver-4.8.0-SNAPSHOT.jar:4.8.0-SNAPSHOT] at org.jivesoftware.openfire.IQRouter.handle(IQRouter.java:394) ~[xmppserver-4.8.0-SNAPSHOT.jar:4.8.0-SNAPSHOT] at org.jivesoftware.openfire.IQRouter.route(IQRouter.java:106) ~[xmppserver-4.8.0-SNAPSHOT.jar:4.8.0-SNAPSHOT] at org.jivesoftware.openfire.spi.PacketRouterImpl.route(PacketRouterImpl.java:74) ~[xmppserver-4.8.0-SNAPSHOT.jar:4.8.0-SNAPSHOT] at org.jivesoftware.openfire.session.LocalOutgoingServerSession.lambda$returnErrorToSenderAsync$0(LocalOutgoingServerSession.java:344) ~[xmppserver-4.8.0-SNAPSHOT.jar:4.8.0-SNAPSHOT] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?] at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?] at java.lang.Thread.run(Thread.java:829) [?:?]

Environment

None

Activity

Show:
Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created September 6, 2023 at 4:58 PM
Updated November 15, 2023 at 1:19 PM
Resolved November 15, 2023 at 1:19 PM

Flag notifications