Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Wrong URL generated for editing groups with space in the names

Description

When trying to edit a group, which has a space in it's name, admin console generates a link https://server:9091/group-edit.jsp?group=test%2Btest instead of https://server:9091/group-edit.jsp?group=test%20test and throws an exception:

Problem accessing /group-edit.jsp. Reason:

Group with name test+bac not found.

Caused by:

org.jivesoftware.openfire.group.GroupNotFoundException: Group with name test+bac not found.
at org.jivesoftware.openfire.group.DefaultGroupProvider.getGroup(DefaultGroupProvider.java:116)
at org.jivesoftware.openfire.group.GroupManager.getGroup(GroupManager.java:330)
at org.jivesoftware.openfire.group.GroupManager.getGroup(GroupManager.java:309)
etc.

Environment

None

Activity

Show:

Tom Evans May 3, 2014 at 12:42 AM

Per earlier XSS fix, group name was being encoded twice on the group summary page; updated to use local variable that has already been properly encoded.

wroot May 2, 2014 at 8:00 PM
Edited

I was testing on Windows 7 x64 box. I've created a group with the name "test test" on 3.9.2 and tried to edit it. Got the exception. Uninstalled, installed 3.9.1. I can edit it now.

Edit: just tested on the production box (3.9.1, Arch linux x86). Works fine.

Walter Ebeling May 2, 2014 at 7:51 PM

Can't confirm this as working on 3.9.1. It's broken on our 64 bit Linux environment.

wroot May 2, 2014 at 7:42 PM

I suspect one of the XSS fixes caused that (OF-686, https://igniterealtime.atlassian.net/browse/OF-705#icft=OF-705). 3.9.1 works fine.

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Affects versions

Priority

Created May 2, 2014 at 7:41 PM
Updated May 3, 2014 at 12:42 AM
Resolved May 3, 2014 at 12:42 AM

Flag notifications