Add support for XEP-0115 Entity Capabilities

Activity

Show:

Robin Collier April 20, 2013 at 9:59 PM

There are 2 issues with using Base 64 for filename encoding.

  • Base 64 produces filenames with '/' that won't work on most (maybe all) file systems).

  • Doesn't work on case insensitive file systems.

Created a filename/url safe version of the StringEncoder to be used instead of the basic Base 64 encoder and also changed the default to use Base 32 encoder as this will work on both case sensitive and insensitive filesystems. The only drawback is longer filenames.

Robin Collier March 31, 2013 at 2:31 PM

Some API changes resulted in deprecated methods that need to be cleaned up.

Robin Collier March 19, 2013 at 11:05 PM

Ignore that assertion failure I mentioned, problem with my launch config. Tests run fine.

Robin Collier March 19, 2013 at 10:42 PM

The tmpDir works fine, the creation of the tmp file using the tmpDir as the prefix is what fails. Changing it to any simple string seems to fix that call, but I don't know if it invalidates the test or not.

I have updated the createTempDIrectory so that it runs and I believe still does what it was intended to do, simply generate a new temporary directory each time it is run.

Now the two testSimpleDirectoryXXX test cases fail on assertions. Funny thing is, I am pretty sure they ran successfully the first couple of times I ran it, then they stopped working.

Florian Schmaus March 19, 2013 at 5:45 PM

The entity caps unit tests use the java.io.tmpdir java property. That should theoretically work on Windows and is a standard way to determine the temp dir of a host system. A quick google search didn't showed no other indication that it should work on Win7. Could you debug the testcase and see what value is returned for java.io.tmpdir?

The entity caps are disabled as default for know. I'd like to keep it that way until the next release. I would simply created an extra issue that a extension documentation is tbd, it should be pretty simply since it's basically only an on/off setting. But given the fact that they are disabled as default I would refer from delaying a future smack release.

Fixed

Details

Assignee

Reporter

Ignite Forum URL

Components

Fix versions

Priority

Created December 14, 2011 at 5:14 PM
Updated October 28, 2020 at 1:28 PM
Resolved March 19, 2013 at 11:11 PM