Spark should parse /me in toast popup

Description

Most client has a special command /me which will be replaced to message sender's nickname in the chat transcript and such message is displayed in special color (pink in Spark). Spark is not replacing /me command in toast popups. So, currently it is displayed like "username says: /me going to bed". I have filed this as a bug some time ago. Though now i feel this could be more as a trivial improvement, if needed at all. Because popup already shows who has said the message. Also one can see that someone has used /me command, without even looking in the chat window.

I wait for suggestions on this. Maybe this could be closed without any changes. Of course such message could be shown in popup like "username is going to bed" and maybe in pink color. Would be nice, but maybe not worth coding

Environment

None

Activity

Show:
wroot
January 17, 2010, 3:12 AM

this is marked as close, i have synced the SVN and compiled the newest version and this still shows the old behavior to me.

Michael Will
January 15, 2010, 2:07 PM

Thanks to Konstantin.

Patch was applyed with a small change
msg.replaceFirst("/me", "")
to:
msg.replaceFirst("/me", getTitle())

Konstantin Zolotarev
January 15, 2010, 11:57 AM

In my patch /me replacing with empty string & set magenta color for message. In cstux's patch /me replacing with users nickname. But i think nickname is already set in title and it don't need in the message body.

wroot
January 15, 2010, 3:24 AM

Pity, but my NetBeans is not accepting this patch. So, what it really does? Michael's fix sounds reasonable. So it just replaces /me to nickname in the toast popup?

Michael Will
January 14, 2010, 10:09 PM

I think we replace this with the name not with nothing.

I have change this line from
msg.replaceFirst("/me", "")
to:
msg.replaceFirst("/me", getTitle())

But I think wroot must decide this, before I will commit this!

Fixed

Priority

Trivial

Assignee

Konstantin Zolotarev

Reporter

wroot