2.7.0: Remove Buzz-Packet, only use Attention-Packet (XEP-0224)

Description

org.jivesoftware.sparkimpl.plugin.alerts.BuzzPacket.java
line : 41

Environment

None

Activity

Show:

wroot April 8, 2015 at 4:58 PM

After more testing i can see that Spark's latest build supports Attention packet (receiving). But disco part is still missing and Pidgin is not sending anything as it thinks Spark doesn't support this or doesn't want to be buzzed. I was able to buzz Spark from Gajim with /attention command though.

wroot April 8, 2015 at 11:21 AM

Just a side note: Smack is supporting XEP-0224 since 3.2.0 version and current Spark 2.7.0 builds already use Smack 3.3.1, so probably Spark shouldn't invent its own feature and use Smack functions to send and receive Attention packets.

wroot March 25, 2013 at 8:28 PM

I think you can create a new ticket for additional disco packet, etc. And maybe rename this ticket's title.

Jason Sipula March 25, 2013 at 3:01 PM

Sorry guys, I've been super busy lately and haven't had much time to continue work.

The other night I did strip the buzz packet portion out on my test build and no negative effects where noted. That is good news and this should close this ticket out.

I think the addition of the disco#info packet should be allocated to a new ticket since that will be a more intensive patch and require some re-plumbing of the attention button to first send out the disco#info and wait for some response. I did confirm via the spark debug window that the disco#info is not being sent. Should I go ahead and create this ticket (and fill in details)?

Jason Sipula March 6, 2013 at 7:04 PM

thanks Wolf for the insight. From what i've seen in the developer-mode console (smack debug console) the disco#info packet is not part of discovery currently. Implementing something that tells the user the feature is disabled on the other client would be nice.

I'll check into this further tonight after work.

Details

Priority

Assignee

Reporter

Affects versions

Created May 4, 2011 at 7:50 AM
Updated April 2, 2017 at 6:48 PM