Issues
- Database update reports success without checkingOF-3045Guus der Kinderen
- Include DB2 Database Drivers in DistributionOF-3042Guus der Kinderen
- RPM build fails in new OJDBC driverOF-2960Resolved issue: OF-2960Guus der Kinderen
- Drop unused database table ofSASLAuthorizedOF-2956Resolved issue: OF-2956Guus der Kinderen
- Update PostgreSQL JDBC driver to 42.7.5OF-2955Resolved issue: OF-2955Daryl Herzmann
- Run all plugin database update scriptsOF-2940Resolved issue: OF-2940Guus der Kinderen
- Database statistics don't observe end-timeOF-2915Resolved issue: OF-2915Guus der Kinderen
- Upgrade postgresql database driver for CVE-2024-1597OF-2802Resolved issue: OF-2802Guus der Kinderen
- Guard against a surplus of database connection errors being loggedOF-2800Resolved issue: OF-2800Guus der Kinderen
- Improve feedback on database setup failureOF-2794Guus der Kinderen
- Include Oracle Database Driver in distributionOF-2793Resolved issue: OF-2793Guus der Kinderen
- Update postgresql driver to 42.6.0OF-2669Resolved issue: OF-2669Daryl Herzmann
- Allow property persistence to be skipped (for tests)OF-2646Resolved issue: OF-2646Guus der Kinderen
- Database errors keep getting logged when providing faulty db connection URL in setupOF-2606Resolved issue: OF-2606Guus der Kinderen
- Oracle Database Driver does not loadOF-2605Guus der Kinderen
- Update SQL Server JDBC driver from 7.4.1 to 9.4.1OF-2588Resolved issue: OF-2588Dan Caseley
- Detect thread obtaining more than one database connectionOF-2572Resolved issue: OF-2572Guus der Kinderen
- Prevent database queries to old wildfire tablesOF-2558Guus der Kinderen
- Distinguish between between 'read' or 'write' database queriesOF-2546Guus der Kinderen
- Stop using text to represent dates or timestampsOF-2500Guus der Kinderen
- Bumps mysql-connector-java from 8.0.27 to 8.0.28.OF-2460Resolved issue: OF-2460Guus der Kinderen
- Drop unused database table ofSASLAuthorizedOF-2442Resolved issue: OF-2442Guus der Kinderen
- Switch HSQLDB's 'payload' column of the 'pubsubItem' table from CLOB to LONGVARCHAROF-2436Guus der Kinderen
- Fix count in database reconnect attemptsOF-2429Resolved issue: OF-2429Guus der Kinderen
- Bump postgresql from 42.2.25 to 42.3.3OF-2394Resolved issue: OF-2394Guus der Kinderen
- Update Postgres driverOF-2387Resolved issue: OF-2387Guus der Kinderen
- Enable Result Set scroll support for OracleOF-2217Resolved issue: OF-2217Guus der Kinderen
- Enable SQL transaction support for MySQLOF-2216Resolved issue: OF-2216Guus der Kinderen
- Use MySQL database scripts for MariaDBOF-2215Resolved issue: OF-2215Guus der Kinderen
- DbConnectionManager should not default to DB2 for unknown database types.OF-2214Resolved issue: OF-2214Guus der Kinderen
- Add JDBC VCardProviderOF-2211Guus der Kinderen
- Openfire SchemaManager#isSQLCommandPart does not support multi-line commentsOF-2198Guus der Kinderen
- Slash-star block comment fails for SQLServerOF-2197Resolved issue: OF-2197Guus der Kinderen
- Update MySQL Connector/J to version 8.0.21OF-2088Resolved issue: OF-2088Dan Caseley
- Start-up behavior when database isn't ready yetOF-2074Guus der Kinderen
- Update PostgreSQL JDBC DriverOF-2055Resolved issue: OF-2055Daryl Herzmann
- Use connection manager for JDBC-based providersOF-2035Guus der Kinderen
- MySQL serverTimezone not setOF-1962Resolved issue: OF-1962Greg Thomas
- Update MySQL Connector/J to version 8.0.17OF-1876Resolved issue: OF-1876Guus der Kinderen
- SQL Syntax error in PubSubPersistenceManager (Sybase/SAP ASE)OF-1844
- In Sybase every column should be defined NONNULL/NULL constraintOF-1818Resolved issue: OF-1818Guus der Kinderen
- Incorrect SQL DELETE statement in PubSub causes exceptionOF-1779Resolved issue: OF-1779Dave Cridland
- Update commons-dbcp2 to 2.6.0OF-1758Resolved issue: OF-1758Greg Thomas
- Update documentation regarding the Oracle database connectorOF-1757Resolved issue: OF-1757Greg Thomas
- Investigate LOBS file growing size issueOF-1756Dave Cridland
- Update to MS SQL Server JDBC Driver 7.2.2.jre8OF-1750Resolved issue: OF-1750Greg Thomas
- DB Connection Pool TweaksOF-1733Resolved issue: OF-1733
- MS SQL database script syntax is wrongOF-1724Resolved issue: OF-1724Dave Cridland
- Easy access to change saving the users Avatar to database setting - ldap.override.avatarOF-1709Resolved issue: OF-1709Greg Thomas
- MS SQL Server upgrade script failsOF-1698Resolved issue: OF-1698Greg Thomas
50 of 114
Database update reports success without checking
Description
Environment
None
Details
Assignee
Guus der KinderenGuus der KinderenReporter
Guus der KinderenGuus der KinderenComponents
Priority
Minor
Details
Details
Assignee
Guus der Kinderen
Guus der Kinderen
Reporter
Guus der Kinderen
Guus der KinderenComponents
Priority
MinorCreated March 20, 2025 at 8:18 PM
Updated March 20, 2025 at 8:41 PM
Activity
Show:
Daryl HerzmannMarch 20, 2025 at 8:41 PM
I read now that executeSQLScript parses the scripts, breaking them at the semi-colon and then runs each as a statement, which should address my concern.
Guus der KinderenMarch 20, 2025 at 8:32 PM
I don’t think that this is caused by the driver: it seems to be our implementation that checks for update scripts, that silently ignores missing update scripts.
Daryl HerzmannMarch 20, 2025 at 8:23 PM
I have seen this situation when running free-form SQL files through a database driver. The default behavior is to not have errors be FATAL. For example, the psql client needs ON_ERROR_STOP=1 set to actually error out when a SQL statement fails. FWIW.
After executing database scripts,
SchemaManagerwill report success without checking if the end state of the database is correct.Upon most errors,
SchemaManagerwill report failure, except when it doesn’t find update script files (the code seems to assume that no update is needed for that particular version). This can lead to scenarios in which no scripts are executed, but success is reported nonetheless.Openfire should check, after running the database scripts, if the installed version matches the expected version.